[webkit-reviews] review granted: [Bug 201020] Rename StringBuilder functions to avoid unclear "append uninitialized" terminology : [Attachment 376972] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 201020: Rename StringBuilder functions to avoid unclear "append
uninitialized" terminology
https://bugs.webkit.org/show_bug.cgi?id=201020

Attachment 376972: Patch

https://bugs.webkit.org/attachment.cgi?id=376972&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 376972
  --> https://bugs.webkit.org/attachment.cgi?id=376972
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376972&action=review

> Source/WTF/wtf/text/StringBuilder.cpp:134
> +    std::memcpy(m_bufferCharacters16, currentCharacters,
static_cast<size_t>(m_length.unsafeGet()) * sizeof(UChar)); // This can't
overflow.

Why did you remove the other "This can't overflow." comment but not this one?