[webkit-reviews] review granted: [Bug 200862] Use makeString and multi-argument StringBuilder::append instead of less efficient multiple appends : [Attachment 376963] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 21 21:03:10 PDT 2019
Ryosuke Niwa <rniwa at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 200862: Use makeString and multi-argument StringBuilder::append instead of
less efficient multiple appends
https://bugs.webkit.org/show_bug.cgi?id=200862
Attachment 376963: Patch
https://bugs.webkit.org/attachment.cgi?id=376963&action=review
--- Comment #23 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 376963
--> https://bugs.webkit.org/attachment.cgi?id=376963
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=376963&action=review
> Source/JavaScriptCore/runtime/TypeSet.cpp:416
> + representation.append(StringView { field.get() }, ", ");
Do we need to explicitly create StringView here?
> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:114
> +
This seems unrelated not that it matters either way.
> Tools/WebKitTestRunner/TestController.cpp:1101
> + response = makeString(TestController::webProcessName(), ": ",
webContentPID, '\n',
> + TestController::networkProcessName(), ": ", networkingPID, '\n');
Should we just call dumpResponse instead?
> Tools/WebKitTestRunner/TestController.cpp:1103
> - builder.append('\n');
> + response = "\n"_s;
And here?
More information about the webkit-reviews
mailing list