[webkit-reviews] review granted: [Bug 201016] Wasm::FunctionParser is failing to enforce maxFunctionLocals. : [Attachment 376962] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 201016: Wasm::FunctionParser is failing to enforce maxFunctionLocals.
https://bugs.webkit.org/show_bug.cgi?id=201016

Attachment 376962: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=376962&action=review




--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 376962
  --> https://bugs.webkit.org/attachment.cgi?id=376962
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=376962&action=review

r=me with comment.

> Source/JavaScriptCore/wasm/WasmFunctionParser.h:118
> +    uint32_t functionSectionsCount;

I think this is not a number of function-sections. So maybe, localGroupCount is
better.

> Source/JavaScriptCore/wasm/WasmFunctionParser.h:121
> +    WASM_PARSER_FAIL_IF(!parseVarUInt32(functionSectionsCount), "can't get
number of Function sections");

Ditto.