[webkit-reviews] review granted: [Bug 193046] Unable to enter text in https://eat.fi : [Attachment 375219] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 21 17:26:34 PDT 2019

Ryosuke Niwa <rniwa at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 193046: Unable to enter text in https://eat.fi

Attachment 375219: Patch


--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 375219
  --> https://bugs.webkit.org/attachment.cgi?id=375219

View in context: https://bugs.webkit.org/attachment.cgi?id=375219&action=review

r=me with the following comments addressed.

> Source/WebCore/html/HTMLEmbedElement.h:46
> +    bool isInteractiveContent() const final { return true; }

Please add this to HTMLAppletElement as well.

> Source/WebCore/html/HTMLIFrameElement.h:56
> +    bool isInteractiveContent() const final { return true; }

And to HTMLFrameElement.

> Source/WebCore/html/HTMLLabelElement.cpp:123
> +    for (const auto* it = &node; it && it != this; it =
it->parentOrShadowHostNode()) {

Use parentElement() or parentElementInComposedTree().
It's suspicious that the specification doesn't use the composed tree for the
purpose of determining this.
It's probably a specification bug.

More information about the webkit-reviews mailing list