[webkit-reviews] review denied: [Bug 200831] Logging in FileSystem::deleteFile should avoid logging unsurprising errors : [Attachment 376932] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Katherine_cheney at apple.com's request
for review:
Bug 200831: Logging in FileSystem::deleteFile should avoid logging unsurprising
errors
https://bugs.webkit.org/show_bug.cgi?id=200831

Attachment 376932: Patch

https://bugs.webkit.org/attachment.cgi?id=376932&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 376932
  --> https://bugs.webkit.org/attachment.cgi?id=376932
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376932&action=review

> Source/WTF/wtf/posix/FileSystemPOSIX.cpp:65
> +bool deleteFile(const String& path, OptionSet<ExpectedError> expectedErrors)

I personally do not like that we're making the API more complex just to avoid
some debug logging. My suggestion would be to not change the API and never
log_error in the ENOENT case (since the file is already not there).

> Source/WTF/wtf/posix/FileSystemPOSIX.cpp:-77
> -	   LOG_ERROR("File failed to delete. Error message: %s",
strerror(errno));

Note that this is debug only logging.