[webkit-reviews] review denied: [Bug 200945] Add default to disable legacy TLS versions : [Attachment 376817] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 200945: Add default to disable legacy TLS versions
https://bugs.webkit.org/show_bug.cgi?id=200945

Attachment 376817: Patch

https://bugs.webkit.org/attachment.cgi?id=376817&action=review




--- Comment #5 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 376817
  --> https://bugs.webkit.org/attachment.cgi?id=376817
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376817&action=review

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:72
> +    auto minimumTLSVersion = [defaults boolForKey:@"WebKitDisableLegacyTLS"]
?

Lets not add another [defaults <fooForKey>] in here. The others need to be
reworked to be API/SPI calls instead of relying on NSUserDefaults. Please do
the same for yours.

Otherwise this all seems fine,