[webkit-reviews] review granted: [Bug 200992] Adopt AVSystemController_ActiveAudioRouteDidChangeNotification : [Attachment 376907] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 21 13:00:31 PDT 2019

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 200992: Adopt AVSystemController_ActiveAudioRouteDidChangeNotification

Attachment 376907: Patch


--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 376907
  --> https://bugs.webkit.org/attachment.cgi?id=376907

View in context: https://bugs.webkit.org/attachment.cgi?id=376907&action=review

> Source/WebCore/Modules/mediastream/MediaStream.h:162
> +    bool shouldOverridePauseDuringRouteChanges() const { return true; }

Nit: I think it would be more logical to flip the question to ask what the
class *should* do, something like "bool shouldPauseOnRouteChange()"

More information about the webkit-reviews mailing list