[webkit-reviews] review granted: [Bug 200981] Get rid of m_weakThis data members now that we have a safe way to call makeWeakPtr() from various threads : [Attachment 376887] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 200981: Get rid of m_weakThis data members now that we have a safe way to
call makeWeakPtr() from various threads
https://bugs.webkit.org/show_bug.cgi?id=200981

Attachment 376887: Patch

https://bugs.webkit.org/attachment.cgi?id=376887&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 376887
  --> https://bugs.webkit.org/attachment.cgi?id=376887
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376887&action=review

>
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
49
> +// Use eager initialization for the WeakPtrFactory since we call
makeWeakPtr() from another thread.

I don't think these comments are necessary.