[webkit-reviews] review granted: [Bug 200985] registrableDomainsToRemoveWebsiteDataFor() does not need to return a HashMap : [Attachment 376892] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 21 10:49:14 PDT 2019
John Wilander <wilander at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 200985: registrableDomainsToRemoveWebsiteDataFor() does not need to return
a HashMap
https://bugs.webkit.org/show_bug.cgi?id=200985
Attachment 376892: Patch
https://bugs.webkit.org/attachment.cgi?id=376892&action=review
--- Comment #2 from John Wilander <wilander at apple.com> ---
Comment on attachment 376892
--> https://bugs.webkit.org/attachment.cgi?id=376892
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=376892&action=review
I believe this has the side effect of allowing multiple entries for the same
RegistrableDomain. That should be fine though, since even if we were to
introduce such a bug, we would still delete the right data.
> Source/WTF/wtf/CrossThreadCopier.h:156
> +
Nice!
More information about the webkit-reviews
mailing list