[webkit-reviews] review granted: [Bug 200937] Remove support for watchOS < 6.0 : [Attachment 376816] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Keith Rollin <krollin at apple.com>'s
request for review:
Bug 200937: Remove support for watchOS < 6.0
https://bugs.webkit.org/show_bug.cgi?id=200937

Attachment 376816: Patch

https://bugs.webkit.org/attachment.cgi?id=376816&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 376816
  --> https://bugs.webkit.org/attachment.cgi?id=376816
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376816&action=review

> Source/WTF/wtf/FeatureDefines.h:195
> +#if (__IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (PLATFORM(APPLETV) &&
__TV_OS_VERSION_MIN_REQUIRED >= 130000) || PLATFORM(WATCHOS)

Should check what __IPHONE_OS_VERSION_MIN_REQUIRED is set to on watchOS 6.0. If
it's >= 130000, the PLATFORM(WATCHOS) clause is not needed.

> Source/WTF/wtf/Platform.h:1620
> +#if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) &&
__IPHONE_OS_VERSION_MIN_REQUIRED >= 110000) || PLATFORM(WATCHOS) ||
(PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 110000)

If IOS_FAMILY includes watchOS, should check what
__IPHONE_OS_VERSION_MIN_REQUIRED is set to on watchOS 6.0. If it's >= 110000,
the PLATFORM(WATCHOS) clause is not needed.

> Source/WTF/wtf/Platform.h:1628
> +#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) ||
PLATFORM(WATCHOS) || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >=
130000)

If IOS_FAMILY includes watchOS, should check what
__IPHONE_OS_VERSION_MIN_REQUIRED is set to on watchOS 6.0. If it's >= 130000,
the PLATFORM(WATCHOS) clause is not needed.

> Source/WebCore/PAL/pal/spi/cocoa/NSKeyedArchiverSPI.h:32
> +#define USE_SECURE_ARCHIVER_API (PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) &&
__IPHONE_OS_VERSION_MIN_REQUIRED >= 110200) || PLATFORM(WATCHOS) ||
(PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 110200))

If IOS_FAMILY includes watchOS, should check what
__IPHONE_OS_VERSION_MIN_REQUIRED is set to on watchOS 6.0. If it's >= 110200,
the PLATFORM(WATCHOS) clause is not needed.

> Source/WebCore/PAL/pal/spi/cocoa/NSKeyedArchiverSPI.h:34
> +#define USE_SECURE_ARCHIVER_FOR_ATTRIBUTED_STRING (PLATFORM(MAC) ||
(PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) ||
PLATFORM(WATCHOS) || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >=
130000))

If IOS_FAMILY includes watchOS, should check what
__IPHONE_OS_VERSION_MIN_REQUIRED is set to on watchOS 6.0. If it's >= 130000,
the PLATFORM(WATCHOS) clause is not needed.