[webkit-reviews] review granted: [Bug 200936] CaptureDeviceManager does not need to be CanMakeWeakPtr : [Attachment 376861] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 21 08:25:32 PDT 2019

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 200936: CaptureDeviceManager does not need to be CanMakeWeakPtr

Attachment 376861: Patch


--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 376861
  --> https://bugs.webkit.org/attachment.cgi?id=376861

View in context: https://bugs.webkit.org/attachment.cgi?id=376861&action=review

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:117
> +static inline AudioObjectPropertyListenerBlock

You could've just left this code where it is, removed the Block_copy, and
replaced the call to weakThis->refreshAudioCaptureDevices() with

> Source/WebCore/platform/mediastream/mac/CoreAudioCaptureDeviceManager.h:51
> +    enum class NotifyIfDevicesHaveChanged { Notify, DoNotNotify };

I don't see why these need to be public now.

More information about the webkit-reviews mailing list