[webkit-reviews] review granted: [Bug 200000] Verify Prefetch and credential behavior : [Attachment 376785] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Rob Buis <rbuis at igalia.com>'s
request for review:
Bug 200000: Verify Prefetch and credential behavior
https://bugs.webkit.org/show_bug.cgi?id=200000

Attachment 376785: Patch

https://bugs.webkit.org/attachment.cgi?id=376785&action=review




--- Comment #17 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 376785
  --> https://bugs.webkit.org/attachment.cgi?id=376785
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376785&action=review

>
LayoutTests/http/wpt/prefetch/resources/main-resource-cross-origin-set-cookie.p
y:11
> +</script>

I was initially confused about this script element and the fact the resource is
loaded with fetch API.
Maybe it should be removed or the response could just be something like 'PASS'
or 'Setting Cookie'.

>
LayoutTests/http/wpt/prefetch/resources/main-resource-cross-origin-vary-cookie.
py:9
> +  window.opener.postMessage(result, '*');

indentation

> LayoutTests/platform/mac-wk1/TestExpectations:742
> +http/wpt/prefetch/link-prefetch-cross-origin-vary-cookie.html [ Skip ]

It seems you could skip the whole http/wpt/prefetch folder here.
And put http/tests/cache/link-prefetch-main-resource.html and
http/tests/cache/link-prefetch-main-resource-iframe.html skip lines below the
'# prefetch not supported in WK1'