[webkit-reviews] review granted: [Bug 200969] Web Inspector: Provide an engineering option to log protocol traffic as text : [Attachment 376853] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 21 02:36:55 PDT 2019


Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 200969: Web Inspector: Provide an engineering option to log protocol
traffic as text
https://bugs.webkit.org/show_bug.cgi?id=200969

Attachment 376853: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=376853&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 376853
  --> https://bugs.webkit.org/attachment.cgi?id=376853
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=376853&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:387
> +	   debuggingGroup.addSetting(WI.settings.engineeringLogProtocolAsText,
WI.unlocalizedString("Log Protocol as Text"));

I'd put this in a "Protocol Logging:" section to match what's there in the
Debug pane.


More information about the webkit-reviews mailing list