[webkit-reviews] review granted: [Bug 200960] Make it easier to pass pointers to WTFCrashWithInfo. : [Attachment 376837] proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 20 18:26:58 PDT 2019

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 200960: Make it easier to pass pointers to WTFCrashWithInfo.

Attachment 376837: proposed patch.


--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 376837
  --> https://bugs.webkit.org/attachment.cgi?id=376837
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=376837&action=review

> Source/WTF/wtf/Assertions.h:625
> +    static_assert(std::is_integral<T>::value || std::is_enum<T>::value ||
std::is_pointer<T>::value, "All types need to be bitwise_cast-able to integral
type for logging");

seems like a bad name for a function that allows pointers.

More information about the webkit-reviews mailing list