[webkit-reviews] review granted: [Bug 200902] [iOS] Should show input view when became first responder if keyboard was showing when the view was resigned : [Attachment 376782] Patch and layout tests

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 200902: [iOS] Should show input view when became first responder if
keyboard was showing when the view was resigned
https://bugs.webkit.org/show_bug.cgi?id=200902

Attachment 376782: Patch and layout tests

https://bugs.webkit.org/attachment.cgi?id=376782&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 376782
  --> https://bugs.webkit.org/attachment.cgi?id=376782
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=376782&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:341
> +    BOOL _shouldShowInputViewForPageReActivation;

Nit - this should probably be …Reactivation instead of …ReActivation.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5277
> +    SetForScope<BOOL> shouldShowInputViewForPageReActivationScope {
_shouldShowInputViewForPageReActivation, startInputSessionPolicy ==
_WKFocusStartsInputSessionPolicyAuto && (self.isFirstResponder ||
_becomingFirstResponder) &&
activityStateChanges.contains(WebCore::ActivityState::IsFocused) &&
_wasResignedWhileShowingInputView };

Nit - we could consider factoring out the self.isFirstResponder ||
_becomingFirstResponder check into a separate method, and just use the helper
in both places.