[webkit-reviews] review granted: [Bug 200181] Identify memcpy loops in b3 : [Attachment 376806] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 20 14:40:17 PDT 2019
Saam Barati <sbarati at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 200181: Identify memcpy loops in b3
https://bugs.webkit.org/show_bug.cgi?id=200181
Attachment 376806: Patch
https://bugs.webkit.org/attachment.cgi?id=376806&action=review
--- Comment #56 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 376806
--> https://bugs.webkit.org/attachment.cgi?id=376806
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=376806&action=review
r=me
Can you also file a bug to make this work with Wasm again?
> Source/JavaScriptCore/ChangeLog:9
> + that will not cause GC tearing and have the correct behaviour when
overlapping regions are passed in.
do you have tests to ensure overlapping works as expected?
> Source/JavaScriptCore/b3/B3ReduceLoopStrength.cpp:446
> + effects.readsPinned = true;
> + effects.writesPinned = true;
Not sure this is quite true.
> JSTests/microbenchmarks/memcpy-wasm.js:7
> +
you should return early from these Wasm tests if WebAssembly is not enabled. I
believe we have some WK clients that don't enable it.
More information about the webkit-reviews
mailing list