[webkit-reviews] review granted: [Bug 196870] Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages : [Attachment 368033] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 196870: Add a WebsiteDataStore delegate to handle AuthenticationChallenge
that do not come from pages
https://bugs.webkit.org/show_bug.cgi?id=196870

Attachment 368033: Patch

https://bugs.webkit.org/attachment.cgi?id=368033&action=review




--- Comment #12 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 368033
  --> https://bugs.webkit.org/attachment.cgi?id=368033
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368033&action=review

> Source/WebKit/NetworkProcess/PingLoad.cpp:151
> +	  
m_networkLoadChecker->networkProcess().authenticationManager().didReceiveAuthen
ticationChallenge(m_parameters.sessionID, 0, 0, challenge,
WTFMove(completionHandler));

This needs rebasing.  The 0's are now empty identifiers.  We might need to make
them nullopt's.

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:54
> +	   , m_hasAuthenticationChallengeSelector([m_delegate.get()
respondsToSelector:@selector(didReceiveAuthenticationChallenge:
completionHandler:)])

extra space