[webkit-reviews] review requested: [Bug 200458] Web Inspector: Implement `queryHolders` Command Line API : [Attachment 376790] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 20 12:32:59 PDT 2019
Devin Rousso <drousso at apple.com> has asked for review:
Bug 200458: Web Inspector: Implement `queryHolders` Command Line API
https://bugs.webkit.org/show_bug.cgi?id=200458
Attachment 376790: Patch
https://bugs.webkit.org/attachment.cgi?id=376790&action=review
--- Comment #44 from Devin Rousso <drousso at apple.com> ---
Created attachment 376790
--> https://bugs.webkit.org/attachment.cgi?id=376790&action=review
Patch
If a holder isn't an object, we should keep looking at successive predecessors
(not just the immediate predecessor) for any objects, as there may be other
non-object predecessors (e.g. `JSMap` may have multiple levels of
`HashMapBucket` before the actual `key` object is reached).
More information about the webkit-reviews
mailing list