[webkit-reviews] review granted: [Bug 200926] [ContentChangeObserver] isConsideredClickable should be able to process elements with no renderers : [Attachment 376784] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 20 11:20:15 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 200926: [ContentChangeObserver] isConsideredClickable should be able to
process elements with no renderers
https://bugs.webkit.org/show_bug.cgi?id=200926

Attachment 376784: Patch

https://bugs.webkit.org/attachment.cgi?id=376784&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 376784
  --> https://bugs.webkit.org/attachment.cgi?id=376784
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376784&action=review

> Source/WebCore/ChangeLog:7
> +	   Now that ContentChangeObserver tracks visible->hidden changes,
isConsideredClickable should be able to deal with elemenets with no renderers. 

elemenets. You should say that this is fixing a crash (not just via the test
case name).


More information about the webkit-reviews mailing list