[webkit-reviews] review granted: [Bug 200921] Variadic StringBuilder::append does not handle upconverting from 8-bit to 16-bit correctly : [Attachment 376771] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 200921: Variadic StringBuilder::append does not handle upconverting from
8-bit to 16-bit correctly
https://bugs.webkit.org/show_bug.cgi?id=200921

Attachment 376771: Patch

https://bugs.webkit.org/attachment.cgi?id=376771&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 376771
  --> https://bugs.webkit.org/attachment.cgi?id=376771
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376771&action=review

r=me with a couple comments

> Source/WTF/wtf/text/StringBuilder.cpp:275
> +UChar* StringBuilder::appendUninitialized16(CheckedInt32 requiredLength)

I’m not a fan of these functions names since they don’t actually append.

What does the “uninitialized” refer to here?

Maybe we should have a prefix like “bufferFor...”?