[webkit-reviews] review granted: [Bug 200920] Unsafe usage of CookieStorageObserver from a background thread : [Attachment 376770] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 20 09:00:00 PDT 2019


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 200920: Unsafe usage of CookieStorageObserver from a background thread
https://bugs.webkit.org/show_bug.cgi?id=200920

Attachment 376770: Patch

https://bugs.webkit.org/attachment.cgi?id=376770&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 376770
  --> https://bugs.webkit.org/attachment.cgi?id=376770
Patch

Sounds like we should add some assertions to ThreadSafeRefCounted, too.  The
name implies that you can't run into problems like this.  I'll bet there are
other double frees out there.


More information about the webkit-reviews mailing list