[webkit-reviews] review granted: [Bug 180731] Web Inspector: Support for JavaScript BigInt : [Attachment 376703] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 20 01:03:14 PDT 2019
Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 180731: Web Inspector: Support for JavaScript BigInt
https://bugs.webkit.org/show_bug.cgi?id=180731
Attachment 376703: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=376703&action=review
--- Comment #21 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 376703
--> https://bugs.webkit.org/attachment.cgi?id=376703
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=376703&action=review
r=me, nice work!
> Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js:76
> + this._value = `${description} [BigInt Not Enabled in Web
Inspector]`;
Should "Not Enabled" be capitalized? Wouldn't this always be shown for WK1?
If so, perhaps we should just leave the `_value` as a string.
More information about the webkit-reviews
mailing list