[webkit-reviews] review granted: [Bug 200747] Web Inspector: have more aggressive checks for dataURLs provided to `console.screenshot` : [Attachment 376602] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 200747: Web Inspector: have more aggressive checks for dataURLs provided to
`console.screenshot`
https://bugs.webkit.org/show_bug.cgi?id=200747

Attachment 376602: Patch

https://bugs.webkit.org/attachment.cgi?id=376602&action=review




--- Comment #14 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 376602
  --> https://bugs.webkit.org/attachment.cgi?id=376602
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376602&action=review

Awesome! r=me

> Source/WebCore/page/PageConsoleClient.cpp:389
> +	       if (possibleTarget.getString(state, base64) &&
base64.startsWithIgnoringASCIICase("data:"_s) && base64.length() > 5) {

Is the `length() > 5` check needed?