[webkit-reviews] review requested: [Bug 200651] Web Inspector: DOMDebugger: support event breakpoints in Worker contexts : [Attachment 376734] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has asked  for review:
Bug 200651: Web Inspector: DOMDebugger: support event breakpoints in Worker
contexts
https://bugs.webkit.org/show_bug.cgi?id=200651

Attachment 376734: Patch

https://bugs.webkit.org/attachment.cgi?id=376734&action=review




--- Comment #7 from Devin Rousso <drousso at apple.com> ---
Created attachment 376734

  --> https://bugs.webkit.org/attachment.cgi?id=376734&action=review

Patch

`WI.DebuggerManager` automatically tries to `pause` all other `WI.Target`s when
it receives a `Debugger.paused` event. If the initial `Debugger.paused` came
from a `Worker`, this would cause the main thread to also become paused.  In
WK1, this would cause the test to hang because the next time any results would
be logged to the page, the debugger would instead pause on that log, which
would get out of sync with the test. The fix to this is simply to avoid running
any JavaScript on the main thread until after we `Debugger.resume`.