[webkit-reviews] review granted: [Bug 200752] WebGPU layers don't show up sometimes : [Attachment 376719] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Justin Fan <justin_fan at apple.com>'s
request for review:
Bug 200752: WebGPU layers don't show up sometimes
https://bugs.webkit.org/show_bug.cgi?id=200752

Attachment 376719: Patch

https://bugs.webkit.org/attachment.cgi?id=376719&action=review




--- Comment #7 from Dean Jackson <dino at apple.com> ---
Comment on attachment 376719
  --> https://bugs.webkit.org/attachment.cgi?id=376719
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376719&action=review

> Source/WebCore/ChangeLog:12
> +	   Reproduction of and writing a test for original issue is
non-trivial. 
> +	   Deferring test creation in favor of higher priority WebGPU efforts.
> +	   Normal WebGPU behavior unaffected and covered by existing tests.

Remove this. You'll just have to live with the shame and not give excuses :)

> Source/WebCore/html/canvas/GPUBasedCanvasRenderingContext.cpp:53
> +	   if (renderBox && renderBox->hasAcceleratedCompositing())

We might even want to ASSERT(renderBox->hasAcceleratedCompositing())

> Source/WebCore/rendering/RenderLayerBacking.cpp:2515
>  #if ENABLE(WEBGL) || ENABLE(ACCELERATED_2D_CANVAS)

Add || ENABLE(WEBGPU)