[webkit-reviews] review granted: [Bug 200834] The default tab index of output and fieldset should be -1 : [Attachment 376568] Fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 19 10:48:41 PDT 2019

Alex Christensen <achristensen at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 200834: The default tab index of output and fieldset should be -1

Attachment 376568: Fixes the bug


--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 376568
  --> https://bugs.webkit.org/attachment.cgi?id=376568
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=376568&action=review

> Source/WebCore/ChangeLog:35
> +	   Test: fast/dom/tabindex-defaults.html

No web platform test?

> Source/WebCore/html/HTMLButtonElement.h:54
> +    int defaultTabIndex() const;

Should this be "override" or "final"?

> Source/WebCore/html/HTMLTextAreaElement.h:116
> +    int defaultTabIndex() const;


More information about the webkit-reviews mailing list