[webkit-reviews] review requested: [Bug 200854] Web Inspector: implement a consistent style and lifecycle for all agents : [Attachment 376642] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Aug 18 10:25:12 PDT 2019
Devin Rousso <drousso at apple.com> has asked for review:
Bug 200854: Web Inspector: implement a consistent style and lifecycle for all
agents
https://bugs.webkit.org/show_bug.cgi?id=200854
Attachment 376642: Patch
https://bugs.webkit.org/attachment.cgi?id=376642&action=review
--- Comment #21 from Devin Rousso <drousso at apple.com> ---
Created attachment 376642
--> https://bugs.webkit.org/attachment.cgi?id=376642&action=review
Patch
Rather than have subclasses implement the command variant of
`enable`/`disable`, create a separate protected member function that is called
by the command variant so that the `errorString` doesn't need to be propagated
More information about the webkit-reviews
mailing list