[webkit-reviews] review granted: [Bug 200543] [Mac] Use the PID of the WebContent process when issuing local file read sandbox extensions : [Attachment 376628] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 200543: [Mac] Use the PID of the WebContent process when issuing local file
read sandbox extensions
https://bugs.webkit.org/show_bug.cgi?id=200543

Attachment 376628: Patch

https://bugs.webkit.org/attachment.cgi?id=376628&action=review




--- Comment #8 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 376628
  --> https://bugs.webkit.org/attachment.cgi?id=376628
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376628&action=review

I think the log message should be changed, but otherwise this looks good. R=me.

> Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:357
> +	   WTFLogAlways("Could not create a '%s' sandbox extension",
path.utf8().data());

Thislog message could leak potentially private user data to our logs. Could you
change it to one of the LOG_DEBUG macros, or perhaps just remove the path from
the log file? it should be enough to log that a file extension could not be
generated.