[webkit-reviews] review granted: [Bug 200865] [ESNext] Support hashbang. : [Attachment 376619] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 17 17:59:14 PDT 2019


Mark Lam <mark.lam at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 200865: [ESNext] Support hashbang.
https://bugs.webkit.org/show_bug.cgi?id=200865

Attachment 376619: Patch

https://bugs.webkit.org/attachment.cgi?id=376619&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 376619
  --> https://bugs.webkit.org/attachment.cgi?id=376619
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376619&action=review

r=me

> JSTests/stress/hashbang.js:20
> +shouldThrowSyntaxError(' #!foo');

Can you also add a case for '\n#!foo'?


More information about the webkit-reviews mailing list