[webkit-reviews] review granted: [Bug 200662] Allow checking whether image was created from JavaScript : [Attachment 376195] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 200662: Allow checking whether image was created from JavaScript
https://bugs.webkit.org/show_bug.cgi?id=200662

Attachment 376195: Patch

https://bugs.webkit.org/attachment.cgi?id=376195&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 376195
  --> https://bugs.webkit.org/attachment.cgi?id=376195
Patch

Normally I suggest that people break down their changes into smaller patches,
but in this case it seems strange to land the new
HTMLImageElement::createdByParser function without the caller. The
implementation looks OK, but I can’t tell the important questions like: If you
create a document and parse an image and then change its attributes and move it
into another document it seems you can "fake" created by parser. So is that a
problem? Depends what we are using this for.