[webkit-reviews] review granted: [Bug 200847] [WHLSL] Enums should be shadowed by local variables : [Attachment 376575] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 200847: [WHLSL] Enums should be shadowed by local variables
https://bugs.webkit.org/show_bug.cgi?id=200847

Attachment 376575: Patch

https://bugs.webkit.org/attachment.cgi?id=376575&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 376575
  --> https://bugs.webkit.org/attachment.cgi?id=376575
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376575&action=review

r=me

> LayoutTests/webgpu/whlsl/structure-field-enumeration-element-clash.html:25
> +

can you add a checkFail like:

```
    void foo() { variable.x; }
```