[webkit-reviews] review granted: [Bug 200847] [WHLSL] Enums should be shadowed by local variables : [Attachment 376575] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 16 19:11:26 PDT 2019

Saam Barati <sbarati at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 200847: [WHLSL] Enums should be shadowed by local variables

Attachment 376575: Patch


--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 376575
  --> https://bugs.webkit.org/attachment.cgi?id=376575

View in context: https://bugs.webkit.org/attachment.cgi?id=376575&action=review


> LayoutTests/webgpu/whlsl/structure-field-enumeration-element-clash.html:25
> +

can you add a checkFail like:

    void foo() { variable.x; }

More information about the webkit-reviews mailing list