[webkit-reviews] review granted: [Bug 200830] [macOS] Emoji with variation selectors are rendered in text style, not emoji style : [Attachment 376534] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 200830: [macOS] Emoji with variation selectors are rendered in text style,
not emoji style
https://bugs.webkit.org/show_bug.cgi?id=200830

Attachment 376534: Patch

https://bugs.webkit.org/attachment.cgi?id=376534&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 376534
  --> https://bugs.webkit.org/attachment.cgi?id=376534
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376534&action=review

> Source/WebCore/platform/graphics/mac/GlyphPageMac.cpp:65
> +	   if (glyphs[i * glyphStep] && glyphs[i * glyphStep] != 0xFFFF) {

Can we make a constexpr for 0xFFFF please?