[webkit-reviews] review granted: [Bug 200782] Fix InBounds speculation of typed array PutByVal and add extra step to integer range optimization to search for equality relationships on the RHS value : [Attachment 376531] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 200782: Fix InBounds speculation of typed array PutByVal and add extra step
to integer range optimization to search for equality relationships on the RHS
value
https://bugs.webkit.org/show_bug.cgi?id=200782

Attachment 376531: Patch

https://bugs.webkit.org/attachment.cgi?id=376531&action=review




--- Comment #17 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 376531
  --> https://bugs.webkit.org/attachment.cgi?id=376531
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376531&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +	   Microbenchmarks give a 40% improvement on the memcpy loop test, and
neutral on the out-of-bounds typed array test.

why not faster on the OOB test? Aren't we skipping repeatedly exitting?

> Source/JavaScriptCore/runtime/JSGenericTypedArrayView.h:132
> +    bool canSetIndexQuickly(unsigned i, JSValue v) const

nit: we typically call this "value", not "v"

> Source/JavaScriptCore/runtime/JSObject.h:370
> +    bool canSetIndexQuickly(unsigned i, JSValue v)

style nit: we typically call this "value", not "v"