[webkit-reviews] review granted: [Bug 200821] Many WebStorage classes do not need to subclass ThreadSafeRefCounted : [Attachment 376518] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 200821: Many WebStorage classes do not need to subclass
ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=200821

Attachment 376518: Patch

https://bugs.webkit.org/attachment.cgi?id=376518&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 376518
  --> https://bugs.webkit.org/attachment.cgi?id=376518
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376518&action=review

r=me

> Source/WebKit/NetworkProcess/WebStorage/LocalStorageNamespace.cpp:54
> +	   return std::make_unique<StorageArea>(isEphemeral == IsEphemeral::Yes
? nullptr : this, WTFMove(securityOrigin), m_quotaInBytes);

Should be makeUnique (here and elsewhere).