[webkit-reviews] review granted: [Bug 200818] StorageManager does not need to subclass RefCounted : [Attachment 376507] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 16 10:27:28 PDT 2019
Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 200818: StorageManager does not need to subclass RefCounted
https://bugs.webkit.org/show_bug.cgi?id=200818
Attachment 376507: Patch
https://bugs.webkit.org/attachment.cgi?id=376507&action=review
--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 376507
--> https://bugs.webkit.org/attachment.cgi?id=376507
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=376507&action=review
r=me
> Source/WebKit/NetworkProcess/WebStorage/StorageManagerSet.cpp:69
> + return
std::make_unique<StorageManager>(WTFMove(localStorageDirectory));
Please consider using WTF::makeUnique (a new helper added yesterday).
More information about the webkit-reviews
mailing list