[webkit-reviews] review granted: [Bug 200807] [JSC] WebAssembly BBQ should switch compile mode for size of modules : [Attachment 376488] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted  review:
Bug 200807: [JSC] WebAssembly BBQ should switch compile mode for size of
modules
https://bugs.webkit.org/show_bug.cgi?id=200807

Attachment 376488: Patch

https://bugs.webkit.org/attachment.cgi?id=376488&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 376488
  --> https://bugs.webkit.org/attachment.cgi?id=376488
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376488&action=review

r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   the sacrifice of start-up time, since BBQ Air bloats so lengthy code
consuming large amount of executable memory.

I suggest /bloats so lengthy code consuming large/bloats such lengthy code, and
thereby consumes a large/.

> Source/JavaScriptCore/runtime/Options.h:495
> +    v(size, webAssemblyBBQAirModeThreshold, isIOS() ? (10 << 20) : 0,
Normal, "If 0, we always use BBQ Air. If Wasm module code size hits this
threshold, we compile Wasm module with B3 BBQ mode.") \

I suggest using 10 * MB instead.

> Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:144
> +    // FIXME: Some webpages use very large Wasm module, and it exhausts all
executable memory in ARM64 devices since the size of executable memory region
is 128MB.

/is 128MB/is only limited to 128MB/.

> Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:145
> +    // The long term solution should be introducing Wasm interpreter. But as
a short term solution, we introduce heuristics switching back to BBQ B3 at the
sacrifice of start-up time,

/should be introducing Wasm interpreter/should be to introduce a Wasm
interpreter/.
/heuristics switching back/heuristics to switch back/.

> Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:146
> +    // since BBQ Air bloats so lengthy code consuming large amount of
executable memory.

I suggest rephrasing as “as BBQ Air bloats such lengthy Wasm code and will
consume a large ...”