[webkit-reviews] review denied: [Bug 200736] Web Inspector: there should be an opposite icon for Eye.svg when we want to hide things instead of showing them : [Attachment 376311] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Devin Rousso
<drousso at apple.com>'s request for review:
Bug 200736: Web Inspector: there should be an opposite icon for Eye.svg when we
want to hide things instead of showing them
https://bugs.webkit.org/show_bug.cgi?id=200736

Attachment 376311: Patch

https://bugs.webkit.org/attachment.cgi?id=376311&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 376311
  --> https://bugs.webkit.org/attachment.cgi?id=376311
Patch

Shouldn't such a toggle be toggling between Eye / Hide?

• Enabled has "Hide" icon => click => Disable + Show "Eye" icon
• Disabled has "Eye" icon => click => Enable + Show "Hide" icon

I like not applying the opacity filter to the status button.