[webkit-reviews] review granted: [Bug 200808] Web Inspector: rename "Invalid Characters" to "Invisible Characters" for clarity : [Attachment 376475] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 16 00:46:22 PDT 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 200808: Web Inspector: rename "Invalid Characters" to "Invisible
Characters" for clarity
https://bugs.webkit.org/show_bug.cgi?id=200808

Attachment 376475: Patch

https://bugs.webkit.org/attachment.cgi?id=376475&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 376475
  --> https://bugs.webkit.org/attachment.cgi?id=376475
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376475&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Setting.js:170
> -    showInvalidCharacters: new WI.Setting("show-invalid-characters", false),
> +    showInvisibleCharacters: new WI.Setting("show-invisible-characters",
!!WI.Setting.migrateValue("show-invalid-characters")),

Nice!


More information about the webkit-reviews mailing list