[webkit-reviews] review granted: [Bug 200799] [FTW] Enable CoreFoundation use if building for Apple target : [Attachment 376449] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 200799: [FTW] Enable CoreFoundation use if building for Apple target
https://bugs.webkit.org/show_bug.cgi?id=200799

Attachment 376449: Patch

https://bugs.webkit.org/attachment.cgi?id=376449&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 376449
  --> https://bugs.webkit.org/attachment.cgi?id=376449
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376449&action=review

> Source/cmake/OptionsFTW.cmake:218
> +    find_package(LibXml2 2.9.1 REQUIRED)

Isn't this just a minimum version?   I think it would be fine if the minimum
version were the same for apple and non-apple.

> Source/cmake/OptionsFTW.cmake:-224
> -    find_package(LibXslt 1.1.32 REQUIRED)

ditto