[webkit-reviews] review granted: [Bug 200526] Use one VM per thread for IDB serialization work in network process : [Attachment 376394] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 200526: Use one VM per thread for IDB serialization work in network process
https://bugs.webkit.org/show_bug.cgi?id=200526

Attachment 376394: Patch

https://bugs.webkit.org/attachment.cgi?id=376394&action=review




--- Comment #19 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 376394
  --> https://bugs.webkit.org/attachment.cgi?id=376394
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376394&action=review

r=me -- but please fix the bug I noticed before landing

> Source/WebCore/Modules/indexeddb/server/IDBSerializationContext.cpp:37
> +static HashMap<PAL::SessionID, IDBSerializationContext*>&
serializationContextMap()

This map can be accessed by multiple threads (one SessionID per thread), so we
need to guard it with a lock.

I'd suggest adding a global WTF::Lock, and using WTF::Locker for the full scope
of the two functions below.