[webkit-reviews] review granted: [Bug 200206] wpt/css/css-images/gradient/color-stops-parsing.html crashes : [Attachment 375047] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 200206: wpt/css/css-images/gradient/color-stops-parsing.html crashes
https://bugs.webkit.org/show_bug.cgi?id=200206

Attachment 375047: Patch

https://bugs.webkit.org/attachment.cgi?id=375047&action=review




--- Comment #3 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 375047
  --> https://bugs.webkit.org/attachment.cgi?id=375047
Patch

r=me
I also found this crash when working on bug 200716 and I locally simply fixed
it by null-checking stop.m_color, but I like much more your fix.
This sharing of the code you did inside this new function writeColorStop() is
cool.