[webkit-reviews] review denied: [Bug 200210] Import css/css-images WPT tests : [Attachment 375057] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 15 09:08:19 PDT 2019

Carlos Alberto Lopez Perez <clopez at igalia.com> has denied Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 200210: Import css/css-images WPT tests

Attachment 375057: Patch


--- Comment #17 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 375057
  --> https://bugs.webkit.org/attachment.cgi?id=375057

The expectations for the tests
css/css-images/multiple-position-color-stop-linear-2.html and
css/css-images/multiple-position-color-stop-radial-2.html are wrongly imported.

This are ref-tests and the expectation file should be an -expected.html and not
an -expected.txt

The issue here is that the W3C test importer is currently unable to correctly
resolve the paths to the expectations of this tests because the expectation
reference uses absolute paths. I suggest to apply the fix from bug 200717 and
re-run the import.

More information about the webkit-reviews mailing list