[webkit-reviews] review granted: [Bug 199986] Use ObjectIdentifier<FrameIdentifierType> for frameIDs : [Attachment 376329] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 14 18:33:25 PDT 2019

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 199986: Use ObjectIdentifier<FrameIdentifierType> for frameIDs

Attachment 376329: Patch


--- Comment #26 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 376329
  --> https://bugs.webkit.org/attachment.cgi?id=376329

View in context: https://bugs.webkit.org/attachment.cgi?id=376329&action=review

> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:208
> -	   return 0;
> +	   return FrameIdentifier { }; // This is explicitly zero; see

Instead of just saying webkit.org/b/159777.
Can we also add a comment about how this is a race with the main frame's

Also, using 0 is quite subtle since that's also the default value of
I wonder if we can use some other explicit value.
e.g. max()-1 since max() is used for hash deleted value.

More information about the webkit-reviews mailing list