[webkit-reviews] review granted: [Bug 199986] Use ObjectIdentifier<FrameIdentifierType> for frameIDs : [Attachment 376329] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Aug 14 18:33:25 PDT 2019
- Previous message (by thread): [webkit-reviews] review requested: [Bug 200747] Web Inspector: have more aggressive checks for dataURLs provided to `console.screenshot` : [Attachment 376338] Patch
- Next message (by thread): [webkit-reviews] review requested: [Bug 200700] [WHLSL] Make length, clamp, operator+, operator-, operator*, operator/, operator[], operator[]=, operator.xy, operator.xy=, native : [Attachment 376340] patch
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 199986: Use ObjectIdentifier<FrameIdentifierType> for frameIDs
https://bugs.webkit.org/show_bug.cgi?id=199986
Attachment 376329: Patch
https://bugs.webkit.org/attachment.cgi?id=376329&action=review
--- Comment #26 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 376329
--> https://bugs.webkit.org/attachment.cgi?id=376329
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=376329&action=review
> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:208
> - return 0;
> + return FrameIdentifier { }; // This is explicitly zero; see
webkit.org/b/159777.
Instead of just saying webkit.org/b/159777.
Can we also add a comment about how this is a race with the main frame's
creation?
Also, using 0 is quite subtle since that's also the default value of
ObjectIdentifier.
I wonder if we can use some other explicit value.
e.g. max()-1 since max() is used for hash deleted value.
- Previous message (by thread): [webkit-reviews] review requested: [Bug 200747] Web Inspector: have more aggressive checks for dataURLs provided to `console.screenshot` : [Attachment 376338] Patch
- Next message (by thread): [webkit-reviews] review requested: [Bug 200700] [WHLSL] Make length, clamp, operator+, operator-, operator*, operator/, operator[], operator[]=, operator.xy, operator.xy=, native : [Attachment 376340] patch
- Messages sorted by:
[ date ]
[ thread ]
[ subject ]
[ author ]
More information about the webkit-reviews
mailing list