[webkit-reviews] review canceled: [Bug 199986] Use ObjectIdentifier<FrameIdentifierType> for frameIDs : [Attachment 376322] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 14 15:54:15 PDT 2019


Chris Dumez <cdumez at apple.com> has canceled Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 199986: Use ObjectIdentifier<FrameIdentifierType> for frameIDs
https://bugs.webkit.org/show_bug.cgi?id=199986

Attachment 376322: Patch

https://bugs.webkit.org/attachment.cgi?id=376322&action=review




--- Comment #23 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 376322
  --> https://bugs.webkit.org/attachment.cgi?id=376322
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376322&action=review

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:316
> +// FIXME: These callbacks should take Optional<WebCore::FrameIdentifier>.

Will take a look into this.


More information about the webkit-reviews mailing list