[webkit-reviews] review granted: [Bug 200555] Web Inspector: Elements: Computed: move the Box Model section to the top : [Attachment 375873] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 14 10:08:00 PDT 2019


Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 200555: Web Inspector: Elements: Computed: move the Box Model section to
the top
https://bugs.webkit.org/show_bug.cgi?id=200555

Attachment 375873: Patch

https://bugs.webkit.org/attachment.cgi?id=375873&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 375873
  --> https://bugs.webkit.org/attachment.cgi?id=375873
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=375873&action=review

This may make sense given it is a fixed size. I think we can give it a shot.
r=me

> Source/WebInspectorUI/ChangeLog:14
> +	   Drive-by: use a different identifier string for the Variable section
so it preserves its own
> +		     collapsed state independent of the Properties section.

All of these drive-bys could have been its own bug.


More information about the webkit-reviews mailing list