[webkit-reviews] review granted: [Bug 200704] Web Inspector: Uncaught Exception: Content request failed. : [Attachment 376247] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 200704: Web Inspector: Uncaught Exception: Content request failed.
https://bugs.webkit.org/show_bug.cgi?id=200704

Attachment 376247: Patch

https://bugs.webkit.org/attachment.cgi?id=376247&action=review




--- Comment #4 from Brian Burg <bburg at apple.com> ---
Comment on attachment 376247
  --> https://bugs.webkit.org/attachment.cgi?id=376247
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376247&action=review

r=me

>> Source/WebInspectorUI/UserInterface/Models/WebSocketResource.js:92
>> +	    console.assert(false, "A WebSocket itself has no content, and
should never be requested of as such.");
> 
> "A WebSocket's content was requested. WebSockets do not have content so the
request is nonsensical."

+1 to Greg's wording :)

> Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js:369
> +	       return;

It would be nice to hook the websocket "response" view into the custom view
machinery, but not necessary to fix this bug.