[webkit-reviews] review granted: [Bug 200691] Web Inspector: Update Esprima to trunk (minor fixes) : [Attachment 376219] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 13 21:58:01 PDT 2019


Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 200691: Web Inspector: Update Esprima to trunk (minor fixes)
https://bugs.webkit.org/show_bug.cgi?id=200691

Attachment 376219: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=376219&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 376219
  --> https://bugs.webkit.org/attachment.cgi?id=376219
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=376219&action=review

rs=me

> Source/WebInspectorUI/ChangeLog:24
> +	   - SpreadProperty => SpreadElement.
> +	   - RestProperty => RestElement.

It seems more like `SpreadProperty`/`RestProperty` was merged into
`SpreadElement`/`RestElement`, rather than a rename.  May be worth mentioning?


More information about the webkit-reviews mailing list