[webkit-reviews] review granted: [Bug 200693] Add phase, block, and node numbers to left margin of DFG graph dumps. : [Attachment 376221] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 200693: Add phase, block, and node numbers to left margin of DFG graph
dumps.
https://bugs.webkit.org/show_bug.cgi?id=200693

Attachment 376221: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=376221&action=review




--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 376221
  --> https://bugs.webkit.org/attachment.cgi?id=376221
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=376221&action=review

> Source/JavaScriptCore/ChangeLog:46
> +	   The numbers in the left margin before the ':' are node number (index
of node in

not sure this I'd call this node number (since node number is the index that's
used as an identifier). Just say node index inside basic block

> Source/JavaScriptCore/dfg/DFGGraph.h:1007
> +    void incPhase() { m_prefix.phaseNumber++; }

maybe call this "nextPhase" or "startingNextPhase"?