[webkit-reviews] review granted: [Bug 200680] Uncaught Exception: content.isJSON is not a function selecting image resource : [Attachment 376186] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 200680: Uncaught Exception: content.isJSON is not a function selecting
image resource
https://bugs.webkit.org/show_bug.cgi?id=200680

Attachment 376186: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=376186&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 376186
  --> https://bugs.webkit.org/attachment.cgi?id=376186
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=376186&action=review

r=me

Interesting.  What's the type of the content for image resources?  I'd imagine
it's a string that's `base64Encoded`?

> Source/WebInspectorUI/ChangeLog:10
> +	   Protect against null, such as there being no request data.

There should already be a guard for protecting against no request data
(`_canShowRequestContentView`).  Was that the issue in this case, or was it
just for `null`?