[webkit-reviews] review granted: [Bug 200456] [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas : [Attachment 376182] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Zhifei Fang
<zhifei_fang at apple.com>'s request for review:
Bug 200456: [results.webkit.org Timeline] Performance improvement - Skip render
offscreen canvas
https://bugs.webkit.org/show_bug.cgi?id=200456

Attachment 376182: Patch

https://bugs.webkit.org/attachment.cgi?id=376182&action=review




--- Comment #8 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 376182
  --> https://bugs.webkit.org/attachment.cgi?id=376182
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=376182&action=review

>
Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineCompone
nts.js:66
> +    */

Not quite sure what the point you're trying to get across with this comment is.

>
Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineCompone
nts.js:78
> +	   return false;

We don't need the else because of early return (it's a WebKit code style policy
buried somewhere in https://webkit.org/code-style-guidelines/, I think)